Add rest-api-spec for unified inference API #120447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
pquentin
added
the
auto-backport
davidkyle
reviewed
Jan 20, 2025
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM
Thanks @pquentin. This change is likely to be superseded by elastic/elasticsearch-specification#3545 which models each inference task type (sparse/dense embedding, rerank, etc) as separate APIs. If elastic/elasticsearch-specification#3545 is merged we will have the same problem and need to create those specs here too.
davidkyle
approved these changes
Jan 21, 2025
Member
Author
|
Thanks for the details! I acknowledge that this is temporary, but that will unblock us in the meantime. |
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #117589, and was only added to the specification in elastic/elasticsearch-specification#3313. Doing that currently breaks our tooling that syncs from Elasticsearch to the Elasticsearch-specification.